fix(isthmus): fix argument order for trim function mapping#714
Merged
andrew-coleman merged 1 commit intosubstrait-io:mainfrom Mar 2, 2026
Merged
fix(isthmus): fix argument order for trim function mapping#714andrew-coleman merged 1 commit intosubstrait-io:mainfrom
andrew-coleman merged 1 commit intosubstrait-io:mainfrom
Conversation
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
nielspardon
requested review from
andrew-coleman,
benbellick,
bestbeforetoday and
vbarua
andrew-coleman
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Calcite/SQL
trimfunction has the following syntax:https://calcite.apache.org/docs/reference.html#character-string-operators-and-functions
While the Substrait
trim,ltrim,rtrimfunctions are defined as:https://github.com/substrait-io/substrait/blob/ee109ad48f149f2e3706d51b597febe86b79b225/extensions/functions_string.yaml#L1299-L1363
This PR fixes the argument order for the trim function mapping in isthmus by swapping the
inputandcharactersarguments during conversion.